-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow sorting by multiple columns in dataframe #10778
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/f726481dce358d07da18a4223793529a357792fb/gradio-5.20.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@f726481dce358d07da18a4223793529a357792fb#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/f726481dce358d07da18a4223793529a357792fb/gradio-client-1.13.1.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/f726481dce358d07da18a4223793529a357792fb/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
UI looks good to me! Is this completley ready for review @hannahblair? Perhaps I'm doing something wrong but I'm not seeing the sorting work reliably in Screen.Recording.2025-03-11.at.7.45.26.AM.mov
|
@abidlabs can you give it another spin? think those points are addressed now. |
Nice @hannahblair! Yes all of those points are addressed, and the PR overall looks good to me. Just a couple of minor suggestions:
![]()
Screen.Recording.2025-03-11.at.8.42.23.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice @hannahblair lgtm with a couple of minor things mentioned above!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @hannahblair the UI looks really great!
Description
Adds the ability to sort by up to three columns.
Closes: #4981
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.sh
Please run these bash scripts to automatically format your code:
bash scripts/format_backend.sh
, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh