-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure gradio_client
is backwards compatible with gradio==3.24.1
#5061
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-5061-all-demos You can install the changes in this PR by running: pip install https://gradio-builds.s3.amazonaws.com/55b00b6da2e4a7e7f2bf4b0f088e74f3eeca9d6b/gradio-3.39.0-py3-none-any.whl |
gradio_client
backwards compatibilitygradio_client
backwards compatibility for gradio==3.24.1
gradio_client
backwards compatibility for gradio==3.24.1
gradio_client
is backwards compatible with gradio==3.24.1
I think we're going to do a hard pin of gradio_client in gradio requirements instead |
We should do both @freddyaboulton -- make this fix to address older versions of |
🎉 Chromatic build completed! There are 0 visual changes to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @abidlabs !
Appreciate the review @freddyaboulton |
The hard pin needs to be updated in CI because the requirements get updated every time we make a release. i'll find that and take care of it. |
Thanks @pngwn ! |
As discussed internally, some of the changes to the client were not fully backwards compatible, which broke older versions of
gradio
if they were using later versions of the client. This fixes that, at least forgradio==3.24.1
(I have not tested other versions ofgradio
).To test:
gradio==3.24.1
gradio_client
from pypigradio_client
from this branch