-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon and link to DuplicateButton #5111
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-5111-all-demos You can install the changes in this PR by running: pip install https://gradio-builds.s3.amazonaws.com/8a61efade2ac88733e08ca86291906f6f58c72aa/gradio-3.39.0-py3-none-any.whl |
Thanks for catching this @aliabd. I agree with having I also think it would be nice if we made the Spaces duplicate logo (screenshotted below) the default |
Ah, thank you for fixing that! |
…o-app/gradio into aliabd/fix-duplicate-button
🎉 Chromatic build completed! There are 0 visual changes to review. |
@abidlabs I added icon/link as params to |
LGTM @aliabd! |
PR #5080 added icon and link params to
gr.Button
andgr.ClearButton
(which inherits fromButton
). But it didn't add them togr.DuplicateButton
andgr.UploadButton
which also inherit fromButton
. That's fine forUploadButton
because it defines its own docstrings, butDuplicateButton
doesn't and inherits its docstrings fromButton
. This broke website docs generation because it was looking for the icon/link params that exist in the docstrings and not in the__init__
.Added icon and link as params to
DuplicateButton
and to its docstrings.