-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in example cache loading event #5636
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/eddaebe3236dd57cc1874661b927e9beceaf9e16/gradio-3.44.4-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@eddaebe3236dd57cc1874661b927e9beceaf9e16#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
test/test_helpers.py
Outdated
# Let the server shut down | ||
time.sleep(1) | ||
|
||
with connect(demo, server_port=7859) as client: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, you launch on the same port to ensure that the server truly has shutdown? I don't think you need to do this.
Even if demo.launch()
were to launch a FastAPI app on a new port, it would still read from the same cache since the ids of the components hasn't changed.
So you can remove the hardcoding of the server ports (which will be better in case this port is occupied)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The time.sleep is to ensure shutdown. Hardcoding the same port is for paranoia 😂 Let me fix.
Bad whitespace! Nice fix @freddyaboulton This actually also fixes: #5521 Left a nit about the tests. Otherwise lgtm! |
…/gradio into 5634-cached-example-event-fix
Description
Closes: #5634
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh