-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated .update()
usage from Interface internals
#5862
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/f6120b83ca73c9173c96013e5c22dd99e7d7da74/gradio-3.47.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@f6120b83ca73c9173c96013e5c22dd99e7d7da74#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a usage of update
in the theme builder but other than that this looks good to me @abidlabs
gradio/gradio/themes/builder_app.py
Line 969 in 4e0d87e
gr.Markdown.update( |
Thanks for the review @freddyaboulton and nice catch. I'll fix the theme builder too and get this in. |
We used the
.update()
logic various places insideInterface
, which meant that a warning was raised e.g. any time you clicked on the Clear button or passed in an iterator. This replaces with modern syntax.Test code: