Make the HTTP requests for the Wasm worker wait for the initial run_code() or run_file() to finish
#5958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code()` or `run_file()` to finish
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/98f864484c6642d3fb223b2bd5e5b7e3871bdab2/gradio-3.48.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@98f864484c6642d3fb223b2bd5e5b7e3871bdab2#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
whitphx
commented
Oct 17, 2023
There was a problem hiding this comment.
|
Works beautifully! Thanks @whitphx :) 
|
abidlabs
approved these changes
Oct 17, 2023
This was referenced Oct 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #5957
This PR includes 2 major changes.
run_file()orrun_code()promise execution to finish. 1c99d20awaitwill be supported withrun_code(). 4a95c94These 2 commits are related but independent, so I recommend to review them one by one.
The first one is the direct solution for the problem of #5957 .
The second one is to support top-level
awaitsyntax withrun_file()or thefilesoption. The sample code of #5957 usesrun_code()or thecodeoption so it could include the top-levelawaitin the code. However, it has not worked with withrun_file()or thefilesoption, so this PR fixes it.