Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground proposal #6040

Merged
merged 10 commits into from
Oct 25, 2023
Merged

playground proposal #6040

merged 10 commits into from
Oct 25, 2023

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Oct 20, 2023

Description

Design proposal for the playground.

After some discussions I thought of a few things that we could do to improve things. Just a proposal, so lmk what you think.

  • First thing I noticed was that we weren't really making use of the whole width of the page. This look good normally but we need all the space we can get with 3 columns.
  • There wasn't really a way to change the size of the code or preview panel, so i made it slidey.
  • Even with slidey, previewing the actual app wasn't ideal, so I added a 'fullscreen' button to the preview pane.
  • I clean up the UI a little to make it feel more 'integrated'.

Closes: #(issue)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 20, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/ef48b91a6c8d74ee4a9d1e837ad10b151a9fa2e4/gradio-3.50.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ef48b91a6c8d74ee4a9d1e837ad10b151a9fa2e4#subdirectory=client/python"

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 20, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
website minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

playground proposal

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@pngwn
Copy link
Member Author

pngwn commented Oct 20, 2023

The gradio logo at the bottom looks weird, need to do something about that.

@aliabd
Copy link
Collaborator

aliabd commented Oct 20, 2023

@pngwn what do you mean about the gradio logo?

@pngwn
Copy link
Member Author

pngwn commented Oct 20, 2023

It looks out of place on a wide screen. Kinda just floating there.

@aliabd aliabd merged commit 5524e59 into main Oct 25, 2023
13 checks passed
@aliabd aliabd deleted the playground-proposal branch October 25, 2023 09:25
This was referenced Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants