Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor normalise_file and annotatedimage/Index.svelte #6777

Closed
wants to merge 7 commits into from

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Dec 13, 2023

Fix suggestions I found when working on #6133

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 13, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/222c1de33d451e80e938395fe6494c470ca92cec/gradio-4.12.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@222c1de33d451e80e938395fe6494c470ca92cec#subdirectory=client/python"

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 13, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/annotatedimage minor
@gradio/client minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Refactor normalise_file and annotatedimage/Index.svelte

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs added the gradio-lite Related to the @gradio/lite library label Dec 27, 2023
@whitphx whitphx marked this pull request as ready for review December 27, 2023 16:14
Copy link
Collaborator

@aliabd aliabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes lgtm! Though probably better to wait for #6133 to be merged first and test before merging this.

@aliabd
Copy link
Collaborator

aliabd commented Jan 2, 2024

I think merging in #6133 threw me off and now not sure how to fix the js/annotatedimage/Index.svelte file. Will wait for you to take a look.

@abidlabs
Copy link
Member

abidlabs commented Feb 8, 2024

Hi @whitphx I recently made a lot of changes to normalise_files (well I got rid of it altogether), just a heads up.

@whitphx
Copy link
Member Author

whitphx commented Feb 9, 2024

Yeah that's a good news!
Will close this PR.

@whitphx whitphx closed this Feb 9, 2024
@whitphx whitphx deleted the refactor-normalise-file branch February 9, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gradio-lite Related to the @gradio/lite library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants