-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update httpx
to httpx>=0.24.1
in requirements.txt
#7443
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/f2a7c46cc215ccee2a125dc429cf80b69b0e323d/gradio-4.19.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@f2a7c46cc215ccee2a125dc429cf80b69b0e323d#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
@@ -3,7 +3,7 @@ altair>=4.2.0,<6.0 | |||
fastapi | |||
ffmpy | |||
gradio_client==0.10.0 | |||
httpx | |||
httpx>=0.24.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do so for the python client as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment led me down a deep rabbit hole. But the upside is that I know our CI a lot better now. Thanks @freddyaboulton! I've addressed it so I'll go ahead and merge
Another good catch. Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
Don't understand why I'm getting these typecheck errors (?) I busted the gh cache but didn't seem to help |
It seems like the CI is using the |
Ok so I've identified the problem. The problem is that we now include I'm changing the order to make sure the local versions of |
We require
httpx>=0.24.1
but this was not explicitly pinned. With lower versions ofhttpx
, you get this error:which I just got, and apparently is a common frustration using Gradio