Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update httpx to httpx>=0.24.1 in requirements.txt #7443

Merged
merged 18 commits into from
Feb 16, 2024
Merged

Update httpx to httpx>=0.24.1 in requirements.txt #7443

merged 18 commits into from
Feb 16, 2024

Conversation

abidlabs
Copy link
Member

We require httpx>=0.24.1 but this was not explicitly pinned. With lower versions of httpx, you get this error:

AsyncConnectionPool.__init__() got an unexpected keyword argument 'socket_options'

which I just got, and apparently is a common frustration using Gradio

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 15, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/f2a7c46cc215ccee2a125dc429cf80b69b0e323d/gradio-4.19.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@f2a7c46cc215ccee2a125dc429cf80b69b0e323d#subdirectory=client/python"

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 15, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
gradio_client patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Update httpx to httpx>=0.24.1 in requirements.txt

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@@ -3,7 +3,7 @@ altair>=4.2.0,<6.0
fastapi
ffmpy
gradio_client==0.10.0
httpx
httpx>=0.24.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do so for the python client as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment led me down a deep rabbit hole. But the upside is that I know our CI a lot better now. Thanks @freddyaboulton! I've addressed it so I'll go ahead and merge

@abidlabs
Copy link
Member Author

Another good catch. Done!

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@abidlabs
Copy link
Member Author

Don't understand why I'm getting these typecheck errors (?) I busted the gh cache but didn't seem to help

@abidlabs
Copy link
Member Author

It seems like the CI is using the gradio_client from pypi instead of the one installed locally hmm

@abidlabs
Copy link
Member Author

abidlabs commented Feb 16, 2024

Ok so I've identified the problem. The problem is that we now include gradio_pdf as a dependency in test/requirements.txt. The problem is that gradio_pdf itself lists gradio as a dependency. When pip looks on pypi, it see that the latest version of gradio itself lists gradio_client==0.0.9 as a dependency so it uninstalls the local version of gradio_client and instead uses gradio_client from pypi.

I'm changing the order to make sure the local versions of gradio and gradio_client are installed last.

@abidlabs abidlabs merged commit b7a97f2 into main Feb 16, 2024
7 checks passed
@abidlabs abidlabs deleted the httpx branch February 16, 2024 23:43
@pngwn pngwn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants