Cache view_api info in server and python client #7888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/ee0da9a1d4b94c42b84c798da0fb1b765172d673/gradio-4.24.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ee0da9a1d4b94c42b84c798da0fb1b765172d673#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
freddyaboulton
requested review from
whitphx,
aliabid94,
dawoodkhan82 and
hannahblair
abidlabs
reviewed
Mar 29, 2024
| @@ -1029,8 +1028,6 @@ def _get_component_type(self, component_id: int): | |||
| ) | |||
|
|
|||
| def _get_parameters_info(self) -> list[ParameterInfo] | None: | |||
| if not self.client._info: | |||
| self._info = self.client._get_api_info() | |||
abidlabs
approved these changes
Mar 29, 2024
|
Thank you for the quick review!! And @pseudotensor for the tip about the test |
Merged
Merged
This was referenced Jun 6, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #7882
The client will call the api info endpoint only once during initialization. The server caches the result because right now it should not change throughout the lifetime of the app. This is for the case where many clients connect to view the api info simultaneously.
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh