Fix flaky render test #8411
Merged
Fix flaky render test #8411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/2095639b8b03fa5b089b4cddfe7eb8a23912289a/gradio-4.31.5-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@2095639b8b03fa5b089b4cddfe7eb8a23912289a#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/2095639b8b03fa5b089b4cddfe7eb8a23912289a/gradio-client-0.19.4.tgz |
🦄 no changes detectedThis Pull Request does not include changes to any packages.__No changes detected. __
|
pngwn
approved these changes
May 29, 2024
dawoodkhan82
pushed a commit
that referenced
this pull request
May 29, 2024
dawoodkhan82
added a commit
that referenced
this pull request
Jun 3, 2024
* fix css * add changeset * Add `--table-text-color` var to fix body text in `Examples` (#8364) * add --table-text-color var * add changeset * format * tweak * add changeset * fix * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> * Include JS Client package in CI for PR testing (#8362) * add js client pkg action * test * Revert "test" This reverts commit 575bcfc. * tweaks (#8374) * chore: update docs.py (#8378) * chore: update docs.py Documention -> Documentation * add changeset * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> * Fix encoding error (#8381) * Set orig_name in python client file uploads (#8371) * Add code * add changeset * URL case --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Hannah <hannahblair@users.noreply.github.com> * Include instructions on starting from someone else's custom component repository (#8386) * Add guide * add changeset * Fix link * add changeset * Add code --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> * Fix bug in reload mode equality check. Better equality conversion for state variables (#8385) * Add code * Add deep equality * add changeset * Add code * add changeset * Update gradio/utils.py Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Add code * Add code * add code --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Change z-index of status tracker (#8372) * change z-index of status tracker * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> * Add CDN installation to JS docs (#8401) * add cdn copy * add changeset * tweak * tweak * add changeset * Update guides/08_gradio-clients-and-lite/02_getting-started-with-the-js-client.md Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * remove version from cdn link * tweak * tweak --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Improve rendering (#8398) * changes * add changeset * changes * changes * changes * changes * changes * changes * changeas * changes * add changeset * changes * add changeset * changes * changes * changes * changes * changes * changes * changes * changes * add changeset * changes * cganges * changes * changes * changes * changes * add changeset * changes * chagnes * changes * changes * changes * changes * changes * js * remove console log * changes * changes * changes * changes * changes * changes * changes * changes * changes * add changeset * changes * chnages * changes * cnages * changes * changes * changes * changes * changes * changes * changes * changes * changes * changes * changes * changes * add changeset * changes * changes * changes * changes * changes * changes * changes * add changeset * changes * changes * changes * changes * changes * changes * changes * changes * changes * changes * changes * add changeset * Add `state.change` listener (#8297) * state changes * changes --------- Co-authored-by: Ali Abid <aliabid94@gmail.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * changes * changes * add changeset * changes * changes * changes * changes * changes * changes * updates * changes * add changeset * changes * changes * add changeset * fix * changes * changes * changes * changes * changes * changes * add changeset * changes --------- Co-authored-by: Ali Abid <aliabid94@gmail.com> Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Render decorator documentation (#8409) * changes * changes * add changeset * fix dependency loop and documentation group * add changeset * changes * fix numbered list * changes * changes --------- Co-authored-by: Ali Abid <aliabid94@gmail.com> Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: aliabd <ali.si3luwa@gmail.com> * Connect heartbeat if state created in render. Also fix config cleanup bug #8407 (#8408) * Add code * add changeset * add changeset * lint --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> * Model3D right-handed coordinate system (#8376) * changes (#8411) Co-authored-by: Ali Abid <aliabid94@gmail.com> * Editable Docs (#8403) * docs intro page and guides * python library docs and js client * reorg * changes * add better hovering * fix broken version routing * add redirects and remove duplicate pages * fix build issues * fix issues * formatting * add changeset * working templates for all components * add other pages * merge * merge * changes * changes * working from templates * changes * refactoring * changes * build working * formatting * importing meta globs * add uploading templates to ci * fixes * add changeset * remove fake version * fix * ignore * formatting * adding render page to docs * add changeset * formatting fix * typo --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> * chore: update versions (#8348) --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Hannah <hannahblair@users.noreply.github.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Xu Song <xusong.vip@gmail.com> Co-authored-by: Freddy Boulton <alfonsoboulton@gmail.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co> Co-authored-by: aliabid94 <aabid94@gmail.com> Co-authored-by: Ali Abid <aliabid94@gmail.com> Co-authored-by: aliabd <ali.si3luwa@gmail.com> Co-authored-by: Dylan Ebert <dylan@huggingface.co> Co-authored-by: pngwn <hello@pngwn.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render test was flaky because sometimes it would start editing a component while it was being re-rendered. Edited the test to start editing the last component in a render first, which ensures the render is complete before starting to edit.