-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an optional height
and overflow scrollbar for the Markdown Component
#8528
Merged
Merged
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d46c767
scrollable-markdown-changes-added
ShruAgarwal 2e9a991
Merge branch 'gradio-app:main' into scrollable-markdown
ShruAgarwal 85f474c
Merge branch 'gradio-app:main' into scrollable-markdown
ShruAgarwal 2b7458a
Merge branch 'gradio-app:main' into scrollable-markdown
ShruAgarwal 6636f78
made suggested changes
ShruAgarwal 9c7831a
added a new story in Storybook
ShruAgarwal 8961a2e
Merge branch 'gradio-app:main' into scrollable-markdown
ShruAgarwal c48dc9f
Merge branch 'main' into scrollable-markdown
abidlabs e1726d4
add changeset
gradio-pr-bot 45e0f08
Merge branch 'main' into scrollable-markdown
abidlabs 369b7fa
add changeset
gradio-pr-bot fd7756a
tweaks
abidlabs 00e65c3
Merge branch 'scrollable-markdown' of github.com:ShruAgarwal/gradio i…
abidlabs b768261
changes
abidlabs 2543557
changes
abidlabs 8fb891d
revert example change
abidlabs 5b48239
tweaks
abidlabs f39865a
demo changes
abidlabs 8dff45c
more tweaks
abidlabs 76b8722
formatting
abidlabs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
{"cells": [{"cell_type": "markdown", "id": "302934307671667531413257853548643485645", "metadata": {}, "source": ["# Gradio Demo: markdown_example"]}, {"cell_type": "code", "execution_count": null, "id": "272996653310673477252411125948039410165", "metadata": {}, "outputs": [], "source": ["!pip install -q gradio "]}, {"cell_type": "code", "execution_count": null, "id": "288918539441861185822528903084949547379", "metadata": {}, "outputs": [], "source": ["import gradio as gr\n", "\n", "css = (\n", " \"footer {display: none !important;} .gradio-container {min-height: 0px !important;}\"\n", ")\n", "\n", "# sample md stolen from https://dillinger.io/\n", "\n", "md = \"\"\"# Dillinger\n", "## _The Last Markdown Editor, Ever_\n", "\n", "This is some `inline code`, it is good.\n", "\n", "[![Build Status](https://travis-ci.org/joemccann/dillinger.svg?branch=master)](https://travis-ci.org/joemccann/dillinger)\n", "\n", "Dillinger is a cloud-enabled, mobile-ready, offline-storage compatible,\n", "AngularJS-powered HTML5 Markdown editor.\n", "\n", "- Type some Markdown on the left\n", "- See HTML in the right\n", "- \u2728Magic \u2728\n", "\n", "## Features\n", "\n", "- Import a HTML file and watch it magically convert to Markdown\n", "- Drag and drop images (requires your Dropbox account be linked)\n", "- Import and save files from GitHub, Dropbox, Google Drive and One Drive\n", "- Drag and drop markdown and HTML files into Dillinger\n", "- Export documents as Markdown, HTML and PDF\n", "\n", "Markdown is a lightweight markup language based on the formatting conventions\n", "that people naturally use in email.\n", "As [John Gruber] writes on the [Markdown site][df1]\n", "\n", "> The overriding design goal for Markdown's\n", "> formatting syntax is to make it as readable\n", "> as possible. The idea is that a\n", "> Markdown-formatted document should be\n", "> publishable as-is, as plain text, without\n", "> looking like it's been marked up with tags\n", "> or formatting instructions.\n", "\n", "This text you see here is *actually- written in Markdown! To get a feel\n", "for Markdown's syntax, type some text into the left window and\n", "watch the results in the right.\n", "\n", "## Tech\n", "\n", "Dillinger uses a number of open source projects to work properly:\n", "\n", "- [AngularJS] - HTML enhanced for web apps!\n", "- [Ace Editor] - awesome web-based text editor\n", "- [markdown-it] - Markdown parser done right. Fast and easy to extend.\n", "- [Twitter Bootstrap] - great UI boilerplate for modern web apps\n", "- [node.js] - evented I/O for the backend\n", "- [Express] - fast node.js network app framework [@tjholowaychuk]\n", "- [Gulp] - the streaming build system\n", "- [Breakdance](https://breakdance.github.io/breakdance/) - HTML\n", "to Markdown converter\n", "- [jQuery] - duh\n", "\n", "And of course Dillinger itself is open source with a [public repository][dill]\n", " on GitHub.\n", "\n", "## Installation\n", "\n", "Dillinger requires [Node.js](https://nodejs.org/) v10+ to run.\n", "\n", "Install the dependencies and devDependencies and start the server.\n", "\n", "```bash\n", "cd dillinger\n", "npm i\n", "node app\n", "```\n", "\n", "For production environments...\n", "\n", "```bash\n", "npm install --production\n", "NODE_ENV=production node app\n", "```\n", "\n", "## Plugins\n", "\n", "Dillinger is currently extended with the following plugins.\n", "Instructions on how to use them in your own application are linked below.\n", "\n", "| Plugin | README |\n", "| ------ | ------ |\n", "| Dropbox | [plugins/dropbox/README.md][PlDb] |\n", "| GitHub | [plugins/github/README.md][PlGh] |\n", "| Google Drive | [plugins/googledrive/README.md][PlGd] |\n", "| OneDrive | [plugins/onedrive/README.md][PlOd] |\n", "| Medium | [plugins/medium/README.md][PlMe] |\n", "| Google Analytics | [plugins/googleanalytics/README.md][PlGa] |\n", "\n", "## Development\n", "\n", "Want to contribute? Great!\n", "\n", "Dillinger uses Gulp + Webpack for fast developing.\n", "Make a change in your file and instantaneously see your updates!\n", "\n", "Open your favorite Terminal and run these commands.\n", "\n", "First Tab:\n", "\n", "```bash\n", "node app\n", "```\n", "\n", "Second Tab:\n", "\n", "```bash\n", "gulp watch\n", "```\n", "\n", "(optional) Third:\n", "\n", "```bash\n", "karma test\n", "```\n", "\n", "#### Building for source\n", "\n", "For production release:\n", "\n", "```bash\n", "gulp build --prod\n", "```\n", "\n", "Generating pre-built zip archives for distribution:\n", "\n", "```bash\n", "gulp build dist --prod\n", "```\n", "\n", "## Docker\n", "\n", "Dillinger is very easy to install and deploy in a Docker container.\n", "\n", "By default, the Docker will expose port 8080, so change this within the\n", "Dockerfile if necessary. When ready, simply use the Dockerfile to\n", "build the image.\n", "\n", "```bash\n", "cd dillinger\n", "docker build -t <youruser>/dillinger:${package.json.version} .\n", "```\n", "\n", "This will create the dillinger image and pull in the necessary dependencies.\n", "Be sure to swap out `${package.json.version}` with the actual\n", "version of Dillinger.\n", "\n", "Once done, run the Docker image and map the port to whatever you wish on\n", "your host. In this example, we simply map port 8000 of the host to\n", "port 8080 of the Docker (or whatever port was exposed in the Dockerfile):\n", "\n", "```bash\n", "docker run -d -p 8000:8080 --restart=always --cap-add=SYS_ADMIN --name=dillinger <youruser>/dillinger:${package.json.version}\n", "```\n", "\n", "> Note: `--capt-add=SYS-ADMIN` is required for PDF rendering.\n", "\n", "Verify the deployment by navigating to your server address in\n", "your preferred browser.\n", "\n", "```bash\n", "127.0.0.1:8000\n", "```\n", "\n", "```python\n", "import gradio as gr\n", "\n", "gr.Blocks() as demo:\n", " gr.Markdown(value=md)\n", "\n", "demo.launch()\n", "```\n", "\n", "```js\n", "function fancyAlert(arg) {\n", " if(arg) {\n", " $.facebox({div:'#foo'})\n", " }\n", "}\n", "```\n", "\n", "## License\n", "\n", "MIT\n", "\n", "**Free Software, Hell Yeah!**\n", "\n", "[//]: # (These are reference links used in the body of this note and get stripped out when the markdown processor does its job. There is no need to format nicely because it shouldn't be seen. Thanks SO - http://stackoverflow.com/questions/4823468/store-comments-in-markdown-syntax)\n", "\n", " [dill]: <https://github.com/joemccann/dillinger>\n", " [git-repo-url]: <https://github.com/joemccann/dillinger.git>\n", " [john gruber]: <http://daringfireball.net>\n", " [df1]: <http://daringfireball.net/projects/markdown/>\n", " [markdown-it]: <https://github.com/markdown-it/markdown-it>\n", " [Ace Editor]: <http://ace.ajax.org>\n", " [node.js]: <http://nodejs.org>\n", " [Twitter Bootstrap]: <http://twitter.github.com/bootstrap/>\n", " [jQuery]: <http://jquery.com>\n", " [@tjholowaychuk]: <http://twitter.com/tjholowaychuk>\n", " [express]: <http://expressjs.com>\n", " [AngularJS]: <http://angularjs.org>\n", " [Gulp]: <http://gulpjs.com>\n", "\n", " [PlDb]: <https://github.com/joemccann/dillinger/tree/master/plugins/dropbox/README.md>\n", " [PlGh]: <https://github.com/joemccann/dillinger/tree/master/plugins/github/README.md>\n", " [PlGd]: <https://github.com/joemccann/dillinger/tree/master/plugins/googledrive/README.md>\n", " [PlOd]: <https://github.com/joemccann/dillinger/tree/master/plugins/onedrive/README.md>\n", " [PlMe]: <https://github.com/joemccann/dillinger/tree/master/plugins/medium/README.md>\n", " [PlGa]: <https://github.com/RahulHP/dillinger/blob/master/plugins/googleanalytics/README.md>\n", "\n", "\"\"\"\n", "with gr.Blocks(css=css) as demo:\n", " gr.Markdown(value=md, header_links=True)\n", "\n", "demo.launch()\n"]}], "metadata": {}, "nbformat": 4, "nbformat_minor": 5} | ||
{"cells":[{"cell_type":"markdown","id":"302934307671667531413257853548643485645","metadata":{},"source":["# Gradio Demo: markdown_example"]},{"cell_type":"code","execution_count":null,"id":"272996653310673477252411125948039410165","metadata":{},"outputs":[],"source":["!pip install -q gradio"]},{"cell_type":"code","execution_count":null,"id":"288918539441861185822528903084949547379","metadata":{},"outputs":[],"source":["import gradio as gr\n","\n","css = (\n"," \"footer {display: none !important;} .gradio-container {min-height: 0px !important;}\"\n",")\n","\n","# sample md stolen from https://dillinger.io/\n","\n","md = \"\"\"# Dillinger\n","## _The Last Markdown Editor, Ever_\n","\n","This is some `inline code`, it is good.\n","\n","[![Build Status](https://travis-ci.org/joemccann/dillinger.svg?branch=master)](https://travis-ci.org/joemccann/dillinger)\n","\n","Dillinger is a cloud-enabled, mobile-ready, offline-storage compatible,\n","AngularJS-powered HTML5 Markdown editor.\n","\n","- Type some Markdown on the left\n","- See HTML in the right\n","- ✨Magic ✨\n","\n","## Features\n","\n","- Import a HTML file and watch it magically convert to Markdown\n","- Drag and drop images (requires your Dropbox account be linked)\n","- Import and save files from GitHub, Dropbox, Google Drive and One Drive\n","- Drag and drop markdown and HTML files into Dillinger\n","- Export documents as Markdown, HTML and PDF\n","\n","Markdown is a lightweight markup language based on the formatting conventions\n","that people naturally use in email.\n","As [John Gruber] writes on the [Markdown site][df1]\n","\n","> The overriding design goal for Markdown's\n","> formatting syntax is to make it as readable\n","> as possible. The idea is that a\n","> Markdown-formatted document should be\n","> publishable as-is, as plain text, without\n","> looking like it's been marked up with tags\n","> or formatting instructions.\n","\n","This text you see here is *actually- written in Markdown! To get a feel\n","for Markdown's syntax, type some text into the left window and\n","watch the results in the right.\n","\n","## Tech\n","\n","Dillinger uses a number of open source projects to work properly:\n","\n","- [AngularJS] - HTML enhanced for web apps!\n","- [Ace Editor] - awesome web-based text editor\n","- [markdown-it] - Markdown parser done right. Fast and easy to extend.\n","- [Twitter Bootstrap] - great UI boilerplate for modern web apps\n","- [node.js] - evented I/O for the backend\n","- [Express] - fast node.js network app framework [@tjholowaychuk]\n","- [Gulp] - the streaming build system\n","- [Breakdance](https://breakdance.github.io/breakdance/) - HTML\n","to Markdown converter\n","- [jQuery] - duh\n","\n","And of course Dillinger itself is open source with a [public repository][dill]\n"," on GitHub.\n","\n","## Installation\n","\n","Dillinger requires [Node.js](https://nodejs.org/) v10+ to run.\n","\n","Install the dependencies and devDependencies and start the server.\n","\n","```bash\n","cd dillinger\n","npm i\n","node app\n","```\n","\n","For production environments...\n","\n","```bash\n","npm install --production\n","NODE_ENV=production node app\n","```\n","\n","## Plugins\n","\n","Dillinger is currently extended with the following plugins.\n","Instructions on how to use them in your own application are linked below.\n","\n","| Plugin | README |\n","| ------ | ------ |\n","| Dropbox | [plugins/dropbox/README.md][PlDb] |\n","| GitHub | [plugins/github/README.md][PlGh] |\n","| Google Drive | [plugins/googledrive/README.md][PlGd] |\n","| OneDrive | [plugins/onedrive/README.md][PlOd] |\n","| Medium | [plugins/medium/README.md][PlMe] |\n","| Google Analytics | [plugins/googleanalytics/README.md][PlGa] |\n","\n","## Development\n","\n","Want to contribute? Great!\n","\n","Dillinger uses Gulp + Webpack for fast developing.\n","Make a change in your file and instantaneously see your updates!\n","\n","Open your favorite Terminal and run these commands.\n","\n","First Tab:\n","\n","```bash\n","node app\n","```\n","\n","Second Tab:\n","\n","```bash\n","gulp watch\n","```\n","\n","(optional) Third:\n","\n","```bash\n","karma test\n","```\n","\n","#### Building for source\n","\n","For production release:\n","\n","```bash\n","gulp build --prod\n","```\n","\n","Generating pre-built zip archives for distribution:\n","\n","```bash\n","gulp build dist --prod\n","```\n","\n","## Docker\n","\n","Dillinger is very easy to install and deploy in a Docker container.\n","\n","By default, the Docker will expose port 8080, so change this within the\n","Dockerfile if necessary. When ready, simply use the Dockerfile to\n","build the image.\n","\n","```bash\n","cd dillinger\n","docker build -t <youruser>/dillinger:${package.json.version} .\n","```\n","\n","This will create the dillinger image and pull in the necessary dependencies.\n","Be sure to swap out `${package.json.version}` with the actual\n","version of Dillinger.\n","\n","Once done, run the Docker image and map the port to whatever you wish on\n","your host. In this example, we simply map port 8000 of the host to\n","port 8080 of the Docker (or whatever port was exposed in the Dockerfile):\n","\n","```bash\n","docker run -d -p 8000:8080 --restart=always --cap-add=SYS_ADMIN --name=dillinger <youruser>/dillinger:${package.json.version}\n","```\n","\n","> Note: `--capt-add=SYS-ADMIN` is required for PDF rendering.\n","\n","Verify the deployment by navigating to your server address in\n","your preferred browser.\n","\n","```bash\n","127.0.0.1:8000\n","```\n","\n","```python\n","import gradio as gr\n","\n","gr.Blocks() as demo:\n"," gr.Markdown(value=md)\n","\n","demo.launch()\n","```\n","\n","```js\n","function fancyAlert(arg) {\n"," if(arg) {\n"," $.facebox({div:'#foo'})\n"," }\n","}\n","```\n","\n","## License\n","\n","MIT\n","\n","**Free Software, Hell Yeah!**\n","\n","[//]: # (These are reference links used in the body of this note and get stripped out when the markdown processor does its job. There is no need to format nicely because it shouldn't be seen. Thanks SO - http://stackoverflow.com/questions/4823468/store-comments-in-markdown-syntax)\n","\n"," [dill]: <https://github.com/joemccann/dillinger>\n"," [git-repo-url]: <https://github.com/joemccann/dillinger.git>\n"," [john gruber]: <http://daringfireball.net>\n"," [df1]: <http://daringfireball.net/projects/markdown/>\n"," [markdown-it]: <https://github.com/markdown-it/markdown-it>\n"," [Ace Editor]: <http://ace.ajax.org>\n"," [node.js]: <http://nodejs.org>\n"," [Twitter Bootstrap]: <http://twitter.github.com/bootstrap/>\n"," [jQuery]: <http://jquery.com>\n"," [@tjholowaychuk]: <http://twitter.com/tjholowaychuk>\n"," [express]: <http://expressjs.com>\n"," [AngularJS]: <http://angularjs.org>\n"," [Gulp]: <http://gulpjs.com>\n","\n"," [PlDb]: <https://github.com/joemccann/dillinger/tree/master/plugins/dropbox/README.md>\n"," [PlGh]: <https://github.com/joemccann/dillinger/tree/master/plugins/github/README.md>\n"," [PlGd]: <https://github.com/joemccann/dillinger/tree/master/plugins/googledrive/README.md>\n"," [PlOd]: <https://github.com/joemccann/dillinger/tree/master/plugins/onedrive/README.md>\n"," [PlMe]: <https://github.com/joemccann/dillinger/tree/master/plugins/medium/README.md>\n"," [PlGa]: <https://github.com/RahulHP/dillinger/blob/master/plugins/googleanalytics/README.md>\n","\n","\"\"\"\n","with gr.Blocks(css=css) as demo:\n"," gr.Markdown(value=md, header_links=True, height='400px')\n","\n","demo.launch()\n"]}],"metadata":{"language_info":{"name":"python"}},"nbformat":4,"nbformat_minor":5} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this style should only be applied if the height is not null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made suggested changes and would request you to review and share your thoughts! :)