-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OS detection for cross-browser compatibility #8784
Fix OS detection for cross-browser compatibility #8784
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/b3369ca18539a4e2c697bebab2441de574b54937/gradio-4.38.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@b3369ca18539a4e2c697bebab2441de574b54937#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/b3369ca18539a4e2c697bebab2441de574b54937/gradio-client-1.3.0.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lappemic! Changes look good to me.
I'll continue to debug what's going on with demos on firefox.
This PR addresses part of the issue described in #8736, where Slider Component Demos and some UI elements were not working correctly in Firefox and Safari.
Changes made:
navigator.userAgentData
with a more compatibleget_os()
functionmeta_key
based on the detected OSThese changes improve compatibility across different browsers, particularly Firefox and Safari. The new implementation:
Note: The demo in Firefox still requires further investigation.
To test:
If anyhone knows how to address the Firefox demo issue i would love to fix this as well.