Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latex Rendering Fix #8822

Merged
merged 7 commits into from
Jul 19, 2024
Merged

Latex Rendering Fix #8822

merged 7 commits into from
Jul 19, 2024

Conversation

dawoodkhan82
Copy link
Collaborator

Description

Fixes how latex is rendered. there was an issue where the markdown parser would apply its rules to latex equations which would cause rendering issues.

Closes: #8780

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 17, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/a413ba1b2056c3feed4480bac46fd140ce1bae69/gradio-4.38.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@a413ba1b2056c3feed4480bac46fd140ce1bae69#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/a413ba1b2056c3feed4480bac46fd140ce1bae69/gradio-client-1.3.0.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 17, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/markdown patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Latex Rendering Fix

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

Haven't taken a deep look at this PR yet, but noticed that the UI tests look off:

image

is latex rendering broken or do the storybook tests need to be updated?

@dawoodkhan82
Copy link
Collaborator Author

@abidlabs I might've broken something. This changes how the markdown/latex is rendered, so might be some bugs.

@abidlabs
Copy link
Member

abidlabs commented Jul 17, 2024

Hmm I tested this branch and its not working for me, for example

import gradio as gr

with gr.Blocks() as demo:
    gr.Markdown("""
    I know $1+1=2$
    """, latex_delimiters=[{ "left": "$", "right": "$", "display": True }])
    
demo.launch()

should render:

image

which it does on main, but here, it produces:

image

@dawoodkhan82
Copy link
Collaborator Author

Yeah it seems I broke it for custom latex_delimiters. Will fix.

@dawoodkhan82 dawoodkhan82 marked this pull request as draft July 18, 2024 00:17
@dawoodkhan82 dawoodkhan82 marked this pull request as ready for review July 18, 2024 08:00
@dawoodkhan82
Copy link
Collaborator Author

@abidlabs Should be fixed now.

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beauitful lgtm @dawoodkhan82!

@dawoodkhan82 dawoodkhan82 merged commit 3a81fb2 into main Jul 19, 2024
8 checks passed
@dawoodkhan82 dawoodkhan82 deleted the latex branch July 19, 2024 01:15
This was referenced Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect LaTeX formula display in gr.chatbot and gr.ChatInterface
3 participants