Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide default slider background #9652

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Hide default slider background #9652

merged 5 commits into from
Oct 14, 2024

Conversation

hannahblair
Copy link
Collaborator

Description

Fixes the slider background showing in Firefox in dark mode.

Closes: #9641

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 10, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/cce9d038425bc26fc70c860a51831f26c7c67a87/gradio-5.1.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@cce9d038425bc26fc70c860a51831f26c7c67a87#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/cce9d038425bc26fc70c860a51831f26c7c67a87/gradio-client-1.6.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/cce9d038425bc26fc70c860a51831f26c7c67a87/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 10, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/slider patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Hide default slider background

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, confirms this fixes the issue on firefox! For some reason, dark mode isn't working for me on Chrome, but assuming it still looks good in dark mode, should be good to merge

@blaisewf
Copy link

Also works fine here!

@hannahblair hannahblair merged commit 35bebf3 into main Oct 14, 2024
11 checks passed
@hannahblair hannahblair deleted the slider-background branch October 14, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradio 5 Slider in dark theme does not display properly on Firefox
4 participants