Ensures tabs with visible set to false are not visible. #9653
Conversation
* add story
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/1b5c622be99c36fdb70f24270990ff0bc7d6f539/gradio-5.1.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@1b5c622be99c36fdb70f24270990ff0bc7d6f539#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/1b5c622be99c36fdb70f24270990ff0bc7d6f539/gradio-client-1.7.0.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/1b5c622be99c36fdb70f24270990ff0bc7d6f539/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
|
Thanks @hannahblair! Looks good, except for one weird thing I noticed, which is that when an invisible tab appears between two visible tabs, it messes up the order. Repro: import gradio as gr
with gr.Blocks() as demo:
with gr.Tab("abc"):
b = gr.Button("Make visible")
with gr.Tab("def", visible=False) as t:
pass
with gr.Tab("ghi"):
pass
b.click(lambda :gr.Tab(visible=True), None, t)
demo.launch()
|
| @@ -27,6 +28,7 @@ const raf = is_browser | |||
| * Create a store with the layout and a map of targets | |||
| * @returns A store with the layout and a map of targets | |||
| */ | |||
| let has_run = new Set<number>(); | |||
| } | ||
| })) || []; | ||
| const child_tab_items = instance.children?.filter( | ||
| if (instance.type === "tabs" && !instance.props.initial_tabs) { |
There was a problem hiding this comment.
@hannahblair This is the main fix, we want to avoid blowing away the tabs but we need to set initial tabs for the first render. This way we will set them once but never again which prevent us overwriting them unnessecarily.
|
Also closes #9648 |
pngwn
changed the title
|
The tabs e2e tests are still failing. Can we fix the implementation or test prior to merge? Compared to main, this PR has 5 e2e test failures instead of 1 (link). Just FYI |
|
I shall look at test! |
Description
Ensures tabs with
visibleset tofalseare not visible.Closes: #9648
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh