Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve select event behaviour in gr.Dataframe #9654

Merged
merged 10 commits into from
Oct 17, 2024
Merged

Conversation

hannahblair
Copy link
Collaborator

Description

Adds a last_selection prop to the dataframe to prevent the select event from getting dispatched unnecessarily.

Closes: #9568

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 10, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/dataframe patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Improve select event behaviour in gr.Dataframe

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 10, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/22913c3b472cf1ea871ddf63c9a9b30a9f5e3d08/gradio-5.1.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@22913c3b472cf1ea871ddf63c9a9b30a9f5e3d08#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/22913c3b472cf1ea871ddf63c9a9b30a9f5e3d08/gradio-client-1.7.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/22913c3b472cf1ea871ddf63c9a9b30a9f5e3d08/dist/lite.js""></script>

@hannahblair hannahblair marked this pull request as ready for review October 14, 2024 22:13
@dawoodkhan82 dawoodkhan82 self-requested a review October 15, 2024 23:31
Copy link
Collaborator

@dawoodkhan82 dawoodkhan82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can confirm this fixes the bug.

@dawoodkhan82
Copy link
Collaborator

If possible can the typecheck error be fixed as part of this PR? https://github.com/gradio-app/gradio/actions/runs/11279025835/job/31368818707?pr=9654

@hannahblair
Copy link
Collaborator Author

If possible can the typecheck error be fixed as part of this PR?

Ah didn't see this! All fixed now though :] Thanks for reviewing!

@hannahblair hannahblair enabled auto-merge (squash) October 16, 2024 21:22
@abidlabs
Copy link
Member

Thanks folks! Will go ahead and get this in to reduce the number of open PRs

@abidlabs abidlabs disabled auto-merge October 17, 2024 18:11
@abidlabs abidlabs merged commit cd7dab7 into main Oct 17, 2024
19 of 23 checks passed
@abidlabs abidlabs deleted the table-select-event branch October 17, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select event invoked when dataframe is updated via select event.
4 participants