-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the behavior of gr.LoginButton
locally and on Spaces
#9659
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/21a46dd3f0fa4ecb5646cc22eba90439f5cf99c9/gradio-5.1.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@21a46dd3f0fa4ecb5646cc22eba90439f5cf99c9#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/21a46dd3f0fa4ecb5646cc22eba90439f5cf99c9/gradio-client-1.6.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/21a46dd3f0fa4ecb5646cc22eba90439f5cf99c9/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
@abidlabs , does this also cover non-space logins? The login does not seem to work locally either. |
Hi @davidberenstein1957 yup it will |
gr.LoginButton
gr.LoginButton
locally and on Spaces
js/button/shared/Button.svelte
Outdated
border: var(--button-border-width) solid | ||
var(--button-secondary-border-color); | ||
background: var(--background-fill-primary); | ||
background: black; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "huggingface" variant should not change depending on the theme, in order to preserve the Hugging Face branding
Should be ready for review, cc @apolinario |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @freddyaboulton, update the style, see screenshots here. |
Thanks for the fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @freddyaboulton @hysts @aliabid94 for the review and feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much more robust, thanks @abidlabs for fixing this!
Closes: #9650
Also changes the fixes the styling of the
gr.LoginButton
as it was not showing up correctlyTest here: https://huggingface.co/spaces/abidlabs/login5?logs=build