-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting title in gr.Info/Warning/Error #9681
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/d7edb5b772f0d5da9ceeda22098ae7e6c7df178c/gradio-5.1.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@d7edb5b772f0d5da9ceeda22098ae7e6c7df178c#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/d7edb5b772f0d5da9ceeda22098ae7e6c7df178c/gradio-client-1.6.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/d7edb5b772f0d5da9ceeda22098ae7e6c7df178c/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
66290bc
to
bcd020d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @ABucket - I think we need to add a title parameter to gr.Error
and we can merge.
please check commit 5b26340 @freddyaboulton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ABucket this PR looks great. Just noticed one thing -- the position of the title
argument is not consistent across Info
, Warning
, and Error
. For consistency and to allow backwards-compatibility to developers who may have provided these arguments positionally, can you make title
the last argument in all of these classes? Thanks!
Thanks for your suggestion! Just fixed, please check commit 0c81060 |
Changes look good, thanks @ABucket. I tested this out and I think it would be better if the title did not support HTML, just a standard string. I'll go ahead and make that change and we can merge this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! test code:
import gradio as gr
import time
def test():
time.sleep(1)
gr.Info("some info", title="new info")
time.sleep(1)
gr.Warning("some warning", title="new <i>warning</i>")
time.sleep(1)
raise gr.Error("some error", title="new error")
# def test():
# time.sleep(1)
# gr.Info("some info")
# time.sleep(1)
# gr.Warning("some warning")
# time.sleep(1)
# raise gr.Error("some error")
with gr.Blocks() as demo:
demo.load(test, None, None)
demo.launch()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, thanks again @ABucket!
Description
Allow users to manually set the title (i.e. through gr.Info("Message", title="Title").
Closes: #9670
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh