-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert Storybook Version Upgrade to Fix Custom Component Devmode #9893
base: main
Are you sure you want to change the base?
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/613b7b39f64de24ea6ce5377c1de13f9887541d3/gradio-5.4.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@613b7b39f64de24ea6ce5377c1de13f9887541d3#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/613b7b39f64de24ea6ce5377c1de13f9887541d3/gradio-client-1.7.1.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/613b7b39f64de24ea6ce5377c1de13f9887541d3/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
hmm, seems storybook build is still failing |
I'm really not sure what is going on here, the error doesn't make any sense. The file it is saying doesn't exist definitely exists, but I'm not sure why it can't resolve it correctly. |
Description
Revert #9794. I tried just removing the svelte-preprocess override in the main
package.json
but the storybook build wouldn't succeed. So I reverted the entire commit. Locally, storybook passes so maybe that's ok?Closes #9879
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh