Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Make the description of the Nexus staging repo configurable #31

Closed
snazy opened this issue May 29, 2020 · 4 comments · Fixed by #36
Closed

RFE: Make the description of the Nexus staging repo configurable #31

snazy opened this issue May 29, 2020 · 4 comments · Fixed by #36
Labels
enhancement New feature or request
Milestone

Comments

@snazy
Copy link

snazy commented May 29, 2020

It would be handy to be able to provide a custom description for the staging repo instead of just a string saying which plugin created it.
Additionally, can you mention the groupId+artifactId+version in the default description of the staging repo?

@marcphilipp
Copy link
Member

It would be handy to be able to provide a custom description for the staging repo instead of just a string saying which plugin created it.

Agreed.

Additionally, can you mention the groupId+artifactId+version in the default description of the staging repo?

Since a staging repo can have more than one group id, artifact id, and version, it's not clear which should be used. That of the root project?

@marcphilipp marcphilipp added the enhancement New feature or request label May 30, 2020
@marcphilipp
Copy link
Member

@szpak We currently replace the description when closing/releasing the staging repo. Is passing a new description mandatory for these operations?

marcphilipp added a commit that referenced this issue May 31, 2020
The description can now be customized on the extension or individual
tasks and now defaults to the GAV of the root project.

Resolves #31.
marcphilipp added a commit that referenced this issue May 31, 2020
The description can now be customized on the extension or individual
tasks and now defaults to the GAV of the root project.

Resolves #31.
@szpak
Copy link
Contributor

szpak commented May 31, 2020

Most likely not and some default comment would be assigned by Nexus. However, I've always passed my own comment, so I'm not sure.

marcphilipp added a commit that referenced this issue Jun 1, 2020
The description can now be customized on the extension or individual
tasks and now defaults to the GAV of the root project.

Resolves #31.
@marcphilipp marcphilipp added this to the 0.1.0 milestone Jun 1, 2020
@snazy
Copy link
Author

snazy commented Jun 2, 2020

Since a staging repo can have more than one group id, artifact id, and version, it's not clear which should be used. That of the root project?

Oh, right, you can have more than one "coordinate". Think, it doesn't really matter which artifact's used to create the description, as long it allows to distinguish different staging repos when you look into the list of staging repos in the Nexus UI. Maybe just the first artifact in a publication or so. If people really care, they can set their own description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants