Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create toolchains.xml dynamically based on envs #150

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

bigdaz
Copy link
Member

@bigdaz bigdaz commented Apr 10, 2024

Different runners have different JDKs installed, so using a hard-coded list for
toolchains.xml doesn't work. With this change, the file is generated based on the available JAVA_HOME_* environment variables.

Fixes #89

Thanks @hfhbd for the contribution!

@bigdaz bigdaz merged commit e21decc into main Apr 10, 2024
168 of 170 checks passed
@bigdaz bigdaz deleted the dd/hfhbd-envToolchains branch April 10, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment variables defined in toolchains.xml are incorrect on ARM runners
2 participants