Refactor to remove duplication #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tresat
force-pushed
the
tt/reduce-duplication-with-oop
branch
from
c8ac46a
to
c2dd489
Compare
Create base AndroidSoftware types that are extended by both Library and Applications and reduce duplication, making all feature extensions available to both types. Lots of other internal cleanup and minor refactoring, remove some helper classes that can be replaced by the base plugin type now. Marks TODOs around NiA code.
Library-specific configuration applied by android library plugin on top of general NiA Android support now.
tresat
force-pushed
the
tt/reduce-duplication-with-oop
branch
from
4a9fcf5
to
cf720f4
Compare
jvandort
reviewed
May 22, 2024
...android/src/main/java/org/gradle/api/experimental/android/AbstractAndroidSoftwarePlugin.java
Show resolved
Hide resolved
jvandort
reviewed
May 22, 2024
...android/src/main/java/org/gradle/api/experimental/android/AbstractAndroidSoftwarePlugin.java
Show resolved
Hide resolved
jvandort
reviewed
May 22, 2024
...gin-android/src/main/java/org/gradle/api/experimental/android/AndroidSoftwareBuildTypes.java
Show resolved
Hide resolved
jvandort
reviewed
May 22, 2024
...java/org/gradle/api/experimental/android/application/StandaloneAndroidApplicationPlugin.java
Show resolved
Hide resolved
jvandort
reviewed
May 22, 2024
| configurations.getByName(name + "Implementation").fromDependencyCollector(dependencies.getImplementation()); | ||
| configurations.getByName(name + "CompileOnly").fromDependencyCollector(dependencies.getCompileOnly()); | ||
| configurations.getByName(name + "RuntimeOnly").fromDependencyCollector(dependencies.getRuntimeOnly()); | ||
| private void configureContentTypeAttributes(Project project) { |
There was a problem hiding this comment.
I'd like to follow-up on this.
jvandort
reviewed
May 22, 2024
...gin-android/src/main/java/org/gradle/api/experimental/android/extensions/ComposeSupport.java
Show resolved
Hide resolved
jvandort
reviewed
May 22, 2024
...rc/main/java/org/gradle/api/experimental/android/library/StandaloneAndroidLibraryPlugin.java
Show resolved
Hide resolved
jvandort
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create base AndroidSoftware types that are extended by both Library and Applications and reduce duplication, making all feature extensions available to both types.
Lots of other internal cleanup and minor refactoring, remove some helper classes that can be replaced by the base plugin type now.
Marks TODOs around NiA code.