Deprecated Plexus @Component annotations are removed #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by gradle/develocity-actions |
etiennestuder
requested changes
Sep 6, 2024
| role = DevelocityListener.class, | ||
| hint = "convention-develocity-maven-extension", | ||
| description = "Configures the Develocity Maven extension for com.myorg" | ||
| ) | ||
| public final class ConventionDevelocityMavenExtensionListener implements DevelocityListener { |
There was a problem hiding this comment.
It would be good to have a consistent naming pattern across all these listener implementations.
- I suggest renaming to simply
ConventionDevelocityListener - The CCUD listeners in the other PR LGTM
| <components> | ||
| <component> | ||
| <role>com.gradle.develocity.agent.maven.api.DevelocityListener</role> | ||
| <role-hint>convention-develocity-maven-extension</role-hint> |
There was a problem hiding this comment.
I would rename it to convention-develocity-listener.
| role = DevelocityListener.class, | ||
| hint = "quarkus-build-cache", | ||
| description = "Make the Quarkus build goal cacheable" | ||
| ) | ||
| public final class QuarkusBuildCacheDevelocityListener implements DevelocityListener { |
There was a problem hiding this comment.
I would rename it to QuarkusBuildCachingDevelocityListener.
| <components> | ||
| <component> | ||
| <role>com.gradle.develocity.agent.maven.api.DevelocityListener</role> | ||
| <role-hint>quarkus-build-cache</role-hint> |
There was a problem hiding this comment.
I would rename it to quarkus-build-caching-develocity-listener.
| <role>com.gradle.develocity.agent.maven.api.DevelocityListener</role> | ||
| <role-hint>quarkus-build-cache</role-hint> | ||
| <implementation>com.gradle.QuarkusBuildCacheDevelocityListener</implementation> | ||
| <description>Make the Quarkus build goal cacheable</description> |
There was a problem hiding this comment.
I would rename it to Makes the Quarkus goals cacheable.
…ocity Shared sample
…ching extension
erichaagdev
force-pushed
the
erichaagdev/remove-plexus-annotations
branch
from
5d7e8c1
to
a8656d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated
@Componentannotations from the Quarkus extension and Maven Convention Develocity extension sample. They have been replaced with a dedicated file atsrc/main/resources/META-INF/plexus/components.xmlinstead.