Maven build caching samples are re-enabled #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by gradle/develocity-actions |
erichaagdev
force-pushed
the
erichaagdev/re-enable-maven-caching-samples
branch
4 times, most recently
from
6957885
to
4a46bc7
Compare
erichaagdev
force-pushed
the
erichaagdev/re-enable-maven-caching-samples
branch
4 times, most recently
from
e040e34
to
405e004
Compare
Properties were sorted alphabetically. It wasn't clear why they were grouped the way they were.
erichaagdev
force-pushed
the
erichaagdev/re-enable-maven-caching-samples
branch
2 times, most recently
from
a3c6b02
to
65364b6
Compare
cdsap
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables the Maven build caching workflow and also adds unhandled parameters that have appeared since the workflow had been disabled.
I've also modernized the workflow to use the
-Ddevelocity.cache.failOnUnhandledParameters=truecommand line parameter to fail the build when there are unhandled parameters. This replaces the manual parsing of logs we needed to do previously. This allows us to also use our own official BVS workflows instead of invoking the scripts directly using a run step.See here for an example of what it looks like when there are any unhandled parameters: https://github.com/gradle/develocity-build-config-samples/actions/runs/11217398403/job/31178869039?pr=1399#step:7:3127