-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the Remote cache experiments for transforms script #1428
Conversation
|
|
297796c
to
1a95523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one documentation nitpick. Please consider approved once you add that.
transforms-caching-experiment/remote-cache-experiment-transforms.sh
Outdated
Show resolved
Hide resolved
transforms-caching-experiment/remote-cache-experiment-transforms.sh
Outdated
Show resolved
Hide resolved
transforms-caching-experiment/remote-cache-experiment-transforms.sh
Outdated
Show resolved
Hide resolved
transforms-caching-experiment/remote-cache-experiment-transforms.sh
Outdated
Show resolved
Hide resolved
transforms-caching-experiment/remote-cache-experiment-transforms.sh
Outdated
Show resolved
Hide resolved
transforms-caching-experiment/remote-cache-experiment-transforms.sh
Outdated
Show resolved
Hide resolved
transforms-caching-experiment/remote-cache-experiment-transforms.sh
Outdated
Show resolved
Hide resolved
|
7e71f4e
to
4fb3f96
Compare
|
|
48cc595
to
33cb90c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just a few more questions / nits.
transforms-caching-experiment/remote-cache-experiment-transforms.sh
Outdated
Show resolved
Hide resolved
transforms-caching-experiment/remote-cache-experiment-transforms.sh
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Haag <ehaag@gradle.com> Signed-off-by: Gašper Kojek <gkojek@gradle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 more things.
transforms-caching-experiment/remote-cache-experiment-transforms.sh
Outdated
Show resolved
Hide resolved
…daemon java processes. This should be safer, while still working the same way in my tests
…ipt, as that's not needed anymore since we're running with --no-daemon
Based on this gist and discussed in the slack thread.
I can also remove the description on how to run the script with select transforms if that's what we want.