Improve failure reporting #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle provides special handling for certain exception types. We now use `DefaultMultiCauseException` consistently to ensure consistent failure reporting.
JLLeitschuh
reviewed
Jan 28, 2024
| } | ||
| if (details == null && result == null) { | ||
| return | ||
| } else if (details == null || result == null) { |
There was a problem hiding this comment.
I'm curious what causes these types to not align such that one is null but not the other.
I definitely think this is the right fix, but I'm confused why this exception was being thrown
There was a problem hiding this comment.
See #103 for more background
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases, the exception message reported by Gradle was insufficient or incorrect.
This PR improves a couple of things:
FinishEvent, rather than reporting incorrectly (handleBuildOperationTypeRaw masks failed build operations #103)