Combine all dependencies for a build invocation into single manifest #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consolidate all types related to GitHub output format under a common directory. - Simplify interface to output GitHub snapshot file
Rather than attempt to split resolved dependencies into separate manifests based on Gradle concepts of sub-project or configuration, we now combine all resolved dependencies into a single GitHub Manifest. There's no direct correlation in Gradle to the "manifest file" concept in GitHub, and we no longer try to shoe-horn a partially correct mapping. A later increment may be to annotate a direct dependency with some hints as to where the dependency is declared, to assist with dependency updates. But this is unlikely to be through a separate "manifest", but instead be via the "metadata" field.
It's not clear if/how the manifest name is used by GitHub, but this will ensure that we provide a unique value for each submission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.