Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default name for root project #23624

Merged
merged 7 commits into from
Feb 1, 2023
Merged

Use default name for root project #23624

merged 7 commits into from
Feb 1, 2023

Conversation

reinsch82
Copy link
Member

@reinsch82 reinsch82 marked this pull request as ready for review January 25, 2023 05:21
@reinsch82 reinsch82 self-assigned this Jan 25, 2023
@reinsch82 reinsch82 requested a review from a team January 25, 2023 05:22
ljacomet
ljacomet requested changes Jan 25, 2023
View reviewed changes
Copy link
Member

@ljacomet ljacomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into that and I believe this solution makes sense.

We should add documentation for this though and I have a comment on the choice of the separator character.

@reinsch82 reinsch82 force-pushed the rdegenfellner/bug/15655/fix_root_mount_gradle_project branch from fe2a8c5 to 7350715 Compare January 25, 2023 08:49
@reinsch82 reinsch82 requested a review from hythloda as a code owner January 25, 2023 09:15
@reinsch82 reinsch82 requested a review from ljacomet January 25, 2023 09:15
@gradle gradle deleted a comment from reinsch82 Jan 26, 2023
@gradle gradle deleted a comment from reinsch82 Feb 1, 2023
@reinsch82 reinsch82 added this to the 8.1 RC1 milestone Feb 1, 2023
@gradle gradle deleted a comment from reinsch82 Feb 1, 2023
@gradle gradle deleted a comment from reinsch82 Feb 1, 2023
@gradle gradle deleted a comment from reinsch82 Feb 1, 2023
@bot-gradle
Copy link
Collaborator

I've triggered a build for you.

wolfs
wolfs approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@wolfs wolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bot-gradle
Copy link
Collaborator

Pre-tested commit build failed.

reinsch82 and others added 7 commits February 1, 2023 19:57
@reinsch82
Use default name for root project
ac3d0dd 
- fixes #15655

Signed-off-by: Reinhold Degenfellner <rdegenfellner@gradle.com>
@reinsch82
Use default name for root project
1a2ebf6 
- generate random part

- fixes #15655

Signed-off-by: Reinhold Degenfellner <rdegenfellner@gradle.com>
@reinsch82
Add tests for root project name generation
ab2afe9 
- part of #15655

Signed-off-by: Reinhold Degenfellner <rdegenfellner@gradle.com>
@reinsch82
Use "-" in generated root project name instead of spaces
7e7cc89 
- part of #15655

Signed-off-by: Reinhold Degenfellner <rdegenfellner@gradle.com>
@reinsch82
Document root project name generation
fc4ab19 
- part of #15655
@reinsch82 @octylFractal
Fix word order in doc
4f0d162 
Co-authored-by: Octavia Togami <otogami@gradle.com>
@reinsch82
Fix word order and formatting
985ed75 
feedback

- part of #15655
@reinsch82 reinsch82 force-pushed the rdegenfellner/bug/15655/fix_root_mount_gradle_project branch from bf98882 to 985ed75 Compare February 1, 2023 19:00
@reinsch82
Copy link
Member Author

@bot-gradle test and merge

@gradle gradle deleted a comment from reinsch82 Feb 1, 2023
@bot-gradle
Copy link
Collaborator

I've triggered a build for you.

@bot-gradle bot-gradle merged commit 5a8483a into master Feb 1, 2023
@bot-gradle bot-gradle deleted the rdegenfellner/bug/15655/fix_root_mount_gradle_project branch February 1, 2023 19:45
@ljacomet ljacomet mentioned this pull request Mar 1, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octylFractal octylFractal octylFractal left review comments

@ljacomet ljacomet ljacomet approved these changes

@wolfs wolfs wolfs approved these changes

@hythloda hythloda hythloda approved these changes

Assignees

@reinsch82 reinsch82

Labels
None yet
Projects
None yet
Milestone
8.1 RC1
Development

Successfully merging this pull request may close these issues.

Builds fail if root project is in root of mount point, with further implications
6 participants
@reinsch82 @bot-gradle @ljacomet @wolfs @octylFractal @hythloda