Skip to content

Support Java 24 for running Gradle #32576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
octylFractal merged 6 commits into from
Apr 3, 2025
Merged

Support Java 24 for running Gradle #32576

octylFractal merged 6 commits into from
Apr 3, 2025

Conversation

@octylFractal
Copy link
Member

@octylFractal octylFractal commented Feb 28, 2025

Fixes #32290

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@octylFractal octylFractal added the a:feature A new functionality label Feb 28, 2025
@octylFractal octylFractal added this to the 8.14 RC1 milestone Feb 28, 2025
@octylFractal octylFractal self-assigned this Feb 28, 2025
@octylFractal octylFractal requested review from a team as code owners February 28, 2025 18:45
@octylFractal octylFractal requested review from a team and big-guy February 28, 2025 18:45
@octylFractal

This comment has been minimized.

Sign in to view
@bot-gradle

This comment has been minimized.

Sign in to view
@bot-gradle

This comment has been minimized.

Sign in to view
lkasso
lkasso reviewed Mar 3, 2025
View reviewed changes
Copy link
Member

@lkasso lkasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM.

@octylFractal octylFractal requested a review from a team as a code owner March 3, 2025 21:11
@octylFractal octylFractal requested review from abstratt and mlopatkin and removed request for a team March 3, 2025 21:11
@octylFractal octylFractal force-pushed the ot/feature/java-24-running branch from f70c4a2 to 723e27b Compare March 3, 2025 21:12
big-guy
big-guy reviewed Mar 3, 2025
View reviewed changes
...-core/src/main/java/org/gradle/internal/instantiation/generator/AsmBackedClassGenerator.java Outdated
Copy link
Member

@big-guy big-guy Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this doing the same thing as AsmClassGeneratorUtils.signature?

Copy link
Member Author

@octylFractal octylFractal Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar, but not exactly. I could move it there but it's very incomplete so I don't know that it should be generally used.

@octylFractal octylFractal mentioned this pull request Mar 4, 2025
Closed
cobexer
cobexer approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@cobexer cobexer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gradle/bt-developer-productivity related changes LGTM!

mlopatkin
mlopatkin reviewed Mar 6, 2025
View reviewed changes
Copy link
Member

@mlopatkin mlopatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core-configuration changes look great! What do you think about adding some tests for generic variable propagation?

@octylFractal
Copy link
Member Author

octylFractal commented Mar 6, 2025

What do you think about adding some tests for generic variable propagation?

I think it's not that valuable because Java 24 tests it on hundreds of other tests, but given that this is the second ask for it I might reconsider.

@octylFractal octylFractal force-pushed the ot/feature/java-24-running branch 3 times, most recently from ef5d9b8 to bd89de9 Compare March 11, 2025 16:53
@octylFractal octylFractal requested a review from a team March 11, 2025 16:53
@octylFractal octylFractal changed the base branch from master to release March 11, 2025 16:53
@octylFractal octylFractal force-pushed the ot/feature/java-24-running branch from bd89de9 to 9ec3df3 Compare March 18, 2025 01:28
@octylFractal octylFractal requested a review from a team March 18, 2025 01:28
@octylFractal octylFractal force-pushed the ot/feature/java-24-running branch from 9ec3df3 to d6a48af Compare March 18, 2025 02:40
@octylFractal octylFractal force-pushed the ot/feature/java-24-running branch from 287ba13 to c90fc81 Compare April 1, 2025 21:18
@octylFractal octylFractal force-pushed the ot/feature/java-24-running branch from c90fc81 to 9bdd870 Compare April 2, 2025 06:52
@octylFractal octylFractal enabled auto-merge April 2, 2025 06:53
@octylFractal octylFractal added this pull request to the merge queue Apr 2, 2025
@bot-gradle
Copy link
Collaborator

bot-gradle commented Apr 2, 2025

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.

@octylFractal octylFractal mentioned this pull request Apr 2, 2025
Closed
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025
@octylFractal octylFractal added this pull request to the merge queue Apr 2, 2025
@bot-gradle
Copy link
Collaborator

bot-gradle commented Apr 2, 2025

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025
@octylFractal octylFractal enabled auto-merge April 2, 2025 17:47
@octylFractal octylFractal added this pull request to the merge queue Apr 2, 2025
@bot-gradle
Copy link
Collaborator

bot-gradle commented Apr 2, 2025

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025
@octylFractal
Update Ivy to 2.5.3
867d81c 
Groovy 4 brings this version, so this ensures we have consistent
versions regardless of the bundleGroovy4 flag
@octylFractal octylFractal force-pushed the ot/feature/java-24-running branch from 95d2e70 to 867d81c Compare April 3, 2025 06:11
@octylFractal octylFractal added this pull request to the merge queue Apr 3, 2025
@bot-gradle
Copy link
Collaborator

bot-gradle commented Apr 3, 2025

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.

Merged via the queue into release with commit 650e4b8 Apr 3, 2025
7 checks passed
@octylFractal octylFractal deleted the ot/feature/java-24-running branch April 3, 2025 07:06
@github-actions github-actions bot mentioned this pull request Apr 3, 2025
Closed
5 tasks
@tschuett tschuett mentioned this pull request Apr 9, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abstratt abstratt abstratt left review comments

@lkasso lkasso lkasso left review comments

@mlopatkin mlopatkin mlopatkin left review comments

@cobexer cobexer cobexer approved these changes

@big-guy big-guy big-guy approved these changes

Assignees

@octylFractal octylFractal

Labels

a:feature A new functionality has:release-notes

Projects

None yet

Milestone

8.14 RC1

Development

Successfully merging this pull request may close these issues.

Support running on Java 24

8 participants

@octylFractal @bot-gradle @cobexer @abstratt @big-guy @lkasso @mlopatkin