Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Play 2.8 support #133

Closed
wants to merge 1 commit into from
Closed

Add Play 2.8 support #133

wants to merge 1 commit into from

Conversation

benmccann
Copy link

Play 2.8 mostly matches Play 2.7, but drops support for Scala 2.11 and uses a newer version of Twirl by default.

Travis is failing for all PRs right now. This won't change that. But it probably doesn't hurt to merge it since it's a pretty simple one

@benmccann benmccann mentioned this pull request Apr 21, 2020
@apflieger
Copy link

There's an other reference to the version support here src/docs/asciidoc/00-intro.adoc

@stephane303
Copy link

stephane303 commented May 30, 2020

How would it be possible to use this before it is merge and published to https://gradle.github.io/playframework/, as it takes forever to be done ?
I am working on a legacy play framework project using gradle, which I do not know very well, so any help for instructions to use the forked plugin would be very appreciated.

....
If anyone needs it, here is how you can do it:

https://proandroiddev.com/tip-work-with-third-party-projects-locally-with-gradle-961d6c9efb02

You will have to add this to settings.gradle, to import the plugin in your project

pluginManagement {
  repositories {
      mavenLocal()
      gradlePluginPortal()
  }
}

@JLLeitschuh
Copy link
Contributor

Are there any tests that validate that this change works?

@benmccann
Copy link
Author

I'm not familiar with the tests in this project. I would hope that they test each version. In any case, I'm no longer using this project, so I won't be updating this PR. Feel free to merge, update, or close as you see fit

@devYonz
Copy link

devYonz commented Jul 20, 2020

Bump on this change...

@JLLeitschuh
Copy link
Contributor

@benmccann can you update your commits so they pass DCO?

Signed-off-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@benmccann
Copy link
Author

Done

I've also signed the Gradle CLA: gradle/gradle#268 (comment)

@ghost
Copy link

ghost commented Sep 17, 2020

@JLLeitschuh Hi, sorry I am new to github. I was trying to push fixes into this PR, but it shows
remote: Permission to gradle/playframework.git denied to me.
I am not sure that I need Permission grant by your guys or I followed by wrong steps?

@cstroe
Copy link
Contributor

cstroe commented Sep 24, 2020

@seyashizuo , you need to fork this repo to your account:

fork-repo

After that, clone your repository locally:

git clone git@github.com:cstroe/playframework.git
cd playframework

Then add benmccann's fork as a remote repository:

git remote add benmccann git@github.com:benmccann/playframework-1.git

Then fetch the changes on his play28 branch (this PR is made from that branch):

git fetch benmccann play28

And create your own local branch from it:

git checkout -b play28 benmccann/play28

Then you collaborate how you see fit (open PR to benmccann's fork to get changes into his brach, or open your own PR to this repository).

@JLLeitschuh
Copy link
Contributor

Thank you @cstroe. @seyashizuo was not my intention to ignore you, I've just been really busy.

@JLLeitschuh
Copy link
Contributor

@benmccann if you can rebase this on master, and add some test to verify that this works, as well as add information to the release notes, I'll be happy to merge this.

I will endeavor to respond quickly. Previously, this PR was blocked by getting CI working on master. Now that this is working, I'm more than happy to push this forward.

@benmccann
Copy link
Author

I'm not using Play anymore at the moment. Someone else can feel free to take this over from me though if there's someone else interested in this

@JLLeitschuh
Copy link
Contributor

JLLeitschuh commented Oct 5, 2020

I'm going to close this PR then. I welcome anyone else to take @benmccann's work here and bring it back to life as a new pull request. Please do insure that any new PR does have test coverage of that new play version. Thanks!

@JLLeitschuh JLLeitschuh closed this Oct 5, 2020
gabizou added a commit to gabizou/playframework that referenced this pull request Oct 19, 2020
Play's 2.8 changelog does not mention much actually needing
to change from the build pipeline perspective, so an easy
string replacement for the integration test fixtures to verify
and test should be enough to verify.

Based on the previous PR from gradle#133, this
expands the changes to ensure the integration tests pass as
well.

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
gabizou added a commit to gabizou/playframework that referenced this pull request Oct 19, 2020
Play's 2.8 changelog does not mention much actually needing
to change from the build pipeline perspective, so an easy
string replacement for the integration test fixtures to verify
and test should be enough to verify.

Based on the previous PR from gradle#133, this
expands the changes to ensure the integration tests pass as
well.

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
gabizou added a commit to gabizou/playframework that referenced this pull request Oct 20, 2020
Play's 2.8 changelog does not mention much actually needing
to change from the build pipeline perspective, so an easy
string replacement for the integration test fixtures to verify
and test should be enough to verify.

Based on the previous PR from gradle#133, this
expands the changes to ensure the integration tests pass as
well.

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants