-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add twirl toolchain support #174
base: master
Are you sure you want to change the base?
Conversation
9c527f3
to
a1a4945
Compare
I've updated the mr to not directly depend on the JavaLauncher class being available, and have moved the code to a new extended TwirlCompile class. The code should now be compatible with the full gradle range currently supported. |
So it looks like the integration tests are failing for this reason
I had fixed a similar issue in #175 |
Signed-off-by: Clayton Walker <cwalker@sofi.org>
a1a4945
to
6317b33
Compare
I misread, that error was about optional and not nullable. I've removed the |
@JLLeitschuh any chance somebody at https://github.com/gradle can check a look? |
Unfortunately, I'm not with Gradle anymore |
@JLLeitschuh Sorry for the ping then. |
@big-guy hello! Any chance somebody at gradle can review these changes? |
So toolchains were added in gradle 6.7, so versions under that would now be unsupported. Example failure on Gradle 6.6
|
Allows for the overriding of the java version used to invoke the twirl template compiler.
Resulting build.gradle.kts syntax would look like
Note that if you're using a new version of java already, you can set the version of java used by the scala compiler via