Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register does not work. But create works. #158

Closed
StefMa opened this issue Sep 2, 2023 · 2 comments
Closed

register does not work. But create works. #158

StefMa opened this issue Sep 2, 2023 · 2 comments
Assignees

Comments

@StefMa
Copy link
Contributor

StefMa commented Sep 2, 2023

This is also in the readme:

wrapperUpgrade {
    gradle {
        register("some-gradle-project") {
            repo.set("my-org/some-gradle-project")
            baseBranch.set("release")
        }
        register("some-samples-gradle-project") {
            repo.set("my-org/some-samples-gradle-project")
            dir.set("samples")
        }
    }
}

But register will not work. It seems the plugin is too late to catch it.
However, create will work.

I'm not sure if this needs to be fixed in the plugin itself or in the readme 🤔

I also ask myself, why does this not matter in the Groovy version 🙃

alextu added a commit that referenced this issue Sep 4, 2023
Make `register` work with Kotlin build scripts (#158)
@StefMa
Copy link
Contributor Author

StefMa commented Sep 4, 2023

Fixed by #160

@StefMa StefMa closed this as completed Sep 4, 2023
@alextu
Copy link
Member

alextu commented Sep 4, 2023

Thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants