Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly parse distributionUrl for Gradle snapshot distributions #69

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Properly parse distributionUrl for Gradle snapshot distributions #69

merged 1 commit into from
Oct 28, 2022

Conversation

clayburn
Copy link
Member

@clayburn clayburn commented Oct 28, 2022 •
edited
Loading

This plugin currently fails on URLs such as https://services.gradle.org/distributions-snapshots/gradle-7.6-20221024231219+0000-bin.zip. This means that, when running on a project that uses a Gradle snapshot distribution, the plugin will not successfully execute. This PR aims to fix that by detecting the -snapshots portion of the URL in the parsing regular expression.

@clayburn clayburn marked this pull request as draft October 28, 2022 13:26
@clayburn clayburn marked this pull request as ready for review October 28, 2022 13:42
etiennestuder
etiennestuder requested changes Oct 28, 2022
View reviewed changes
Copy link
Member

@etiennestuder etiennestuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please also make it work for RCs and milestones. See here for the format:
https://services.gradle.org/distributions/

@clayburn
Copy link
Member Author

LGTM. Can you please also make it work for RCs and milestones. See here for the format: https://services.gradle.org/distributions/

I verified that RCs and milestones work both with this changeset and on previous version (v0.10.2, v0.11). The urls for RCs and milestones use /distributions, so were not subject to this issue.

@etiennestuder
Copy link
Member

LGTM. Can you please also make it work for RCs and milestones. See here for the format: https://services.gradle.org/distributions/

I verified that RCs and milestones work both with this changeset and on previous version (v0.10.2, v0.11). The urls for RCs and milestones use /distributions, so were not subject to this issue.

Got it. Thanks for the clarification. Let's merge it.

@clayburn clayburn merged commit 6fc8159 into main Oct 28, 2022
@clayburn clayburn deleted the cjohnson/parse-gradle-snapshot-distributions-urls branch October 28, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennestuder etiennestuder etiennestuder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clayburn @etiennestuder