-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tensorboard callbacks #173
Conversation
…training and validation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @arvindmuralie77! Thank you for opening your first pull request in this repo. We are so happy that you have decided to contribute and value your contribution. Please read these materials before proceeding: Contributing Guide and Code of Conduct.
Codecov Report
@@ Coverage Diff @@
## main #173 +/- ##
==========================================
- Coverage 96.75% 94.99% -1.77%
==========================================
Files 68 69 +1
Lines 2064 2117 +53
==========================================
+ Hits 1997 2011 +14
- Misses 67 106 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@arvindmuralie77 awesome work, feel free to set the PR for review when you're ready. |
@aniketmaurya set the PR as ready for review |
Looks good! Do wanna add logging for step_loss as well in this PR or maybe a next PR? |
Sure I'll add step_loss in this PR |
Hey, @aniketmaurya should I also plot the metrics for every step epoch? |
Sure, let's log metrics for every |
You can check to the Wandb callback for reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for your contribution 🎉
for more information, see https://pre-commit.ci
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@aniketmaurya added functionality for plotting metrics and loss for every |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Let's merge this now.
Changes
Fixes #123
Type of change
Checklist
Solves issue #123
I have added basic tensorboard callback functionality which include: logging the loss and accuracy for both training and validation.
Is there any other functionality of tensorboard that I need to add @aniketmaurya