Multiple Environment Support #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alvagante This is the one I was talking about for review and merge, thanks. :) |
alvagante
reviewed
Sep 3, 2018
| @@ -13,7 +13,9 @@ def send_mail ( | |||
| file_name, | |||
| receiver, | |||
| sender, | |||
| envirnmnt, | |||
| @@ -36,6 +38,7 @@ def send_mail ( | |||
|
|
|||
| # open the file to be sent | |||
| filename = os.path.basename(file_name) | |||
| attachment_name = environment + "-" + filename | |||
| @@ -216,6 +216,7 @@ | |||
| Hash $setenv_safe = {}, | |||
| String $up = '', | |||
| String $down = '', | |||
| String $environment = 'prod', | |||
There was a problem hiding this comment.
Better not to use local class variables called $environment, as they might create confusion with Puppet's interla variable $environment .
Use $env or something similar, here and in line 325.
Anyway, current code should work the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Environment variable
Environment variable to appear on mail sent to client which will distinguish between environments
Adding to subject:
OpenVPN Configuration for us-east-2_prod environment
And file attached will be -.ovpn