Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG FIX: String type columns typecasted as number #152

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

BUG FIX: String type columns typecasted as number #152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d8af80
fixed string type columns typecasted as number
Mar 24, 2023
8cb4de5
not changing type for bool
Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/druid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,14 @@ func (ds *druidDatasource) executeQuery(queryRef string, q druidquerybuilder.Que
Type string
}{Name: c.(string)}
detectColumnType(&col, i, r.Rows)
// len of sqlr > 1, we can infer string and number types from the data row (string is in "quotes") also, time is also in string format
switch sqlr[1].([]interface{})[i].(type) {
case string:
if col.Type != "time" && col.Type != "bool" {
// if the data type is string and not detected as time or bool, keep it as string
col.Type = "string"
}
}
r.Columns = append(r.Columns, col)
}
}
Expand Down