Permit invocation without configuration file, for promoting ad hoc operations #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
commented
Apr 23, 2024
amotl
force-pushed
the
noconfig
branch
2 times, most recently
from
91d4a0f
to
2cef059
Compare
amotl
commented
Apr 23, 2024
amotl
changed the title
amotl
force-pushed
the
tests
branch
4 times, most recently
from
0cb2462
to
a333ab6
Compare
|
The feature is a good idea. |
peekjef72
reviewed
Apr 24, 2024
In this mode, the Grafana URL can optionally be defined using the environment variable `GRAFANA_URL`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
The idea of this patch is to make it possible to invoke
grafana-importwithout needing to use a configuration file, in order to promote ad hoc use. We hope it will be received well.Usage
Instead of defining Grafana connectivity settings within the configuration file, the program now also supports defining it through the command line argument
--grafana_url, and the environment variableGRAFANA_URL, in the same way likegrafana-clientis doing it.Details
In this spirit, this feature expands into quite the opposite direction what the program was originally conceived for, using a configuration file which can store multiple Grafana connection profiles. We think the program can well be used for both use cases, so this patch relaxes the must-have constraint about having a configuration file.
Trivia
This is a stacked PR, based on GH-8. It can be reviewed independently, but please do not merge prematurely.
References