Global secrets normalization

[EvertonSA]

Hi colleagues,

I have experienced with other charts the following behaviors:

• if global is set, and "local" is not, use global
• if global is set, and local is set, use local

but for grafana-agent pull secrets, we are, if I understood correctly, adding up globals and locals. I would like to know if this is the intended or if I'm misunderstanding globals and locals.

agent/operations/helm/charts/grafana-agent/templates/controllers/_pod.yaml

Line 20 in 9a10fff

{{- if .Values.global.image.pullSecrets }}

I have tried to install grafana-agent together with tempo-distributed and bumped into the following issue. Tempo-distributed is using the global pullSecret as a list of strings, and grafana-agent expect pullSecrets as a list of dict. Tempo is clearly not following convention, but due to the behavior above, i'm not able to override the global with a local pullSecret definition.

Error: UPGRADE FAILED: failed to create resource: DaemonSet in version "v1" cannot be handled as a DaemonSet: json: cannot unmarshal string into Go struct field PodSpec.spec.template.spec.imagePullSecrets of type v1.LocalObjectReference

see grafana/helm-charts#2832

[EvertonSA]

thinking out on this problem again, I think grafana-agent should follow grafana behavior https://github.com/grafana/helm-charts/pull/2035/files where it adds up locals and globals, but use the well know .Values.global.imagePullSecrets instead of pullSecrets

[EvertonSA]

i have forked for now