Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow: rename targets.mutate component to discovery.relabel #2077

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

tpaschalis
Copy link
Member

@tpaschalis tpaschalis commented Aug 26, 2022

PR Description

As described in #2059, we would like to set up some conventions in the naming of Flow component.

This PR renames the targets.mutate component and adds it under the discovery namespace as discovery.relabel.

Which issue(s) this PR fixes

No issue filed

Notes to the Reviewer

None, for now.

PR Checklist

  • CHANGELOG updated (N/A until Flow PoC is announced, I think)
  • Documentation added
  • Tests updated

Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
@tpaschalis tpaschalis self-assigned this Aug 26, 2022

## Example

```river
targets.mutate "keep-backend-only" {
discovery.relabel "keep_backend_only" {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block labels must now be valid identifiers. Personal reminder to run any examples present as we're cleaning up the components to verify everything's working properly.

@tpaschalis tpaschalis marked this pull request as ready for review August 26, 2022 13:23
@tpaschalis tpaschalis requested a review from mattdurham August 26, 2022 13:23
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpaschalis tpaschalis merged commit 65fa358 into grafana:main Aug 29, 2022
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants