component/otelcol: use zap adapter to accept logs from wrapped components #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents This introduces component/otelcol/internal/zapadapter, which creates a *zap.Logger instance from a github.com/go-kit/log.Logger instance. This is then used when creating OpenTelemetry Collector components, allowing us to continue to use github.com/go-kit/log consistently throughout Flow. Related to grafana#2213.
rfratto
commented
Oct 3, 2022
Comment on lines
+114
to
+126
| func (fe *fieldEncoder) AddArray(key string, marshaler zapcore.ArrayMarshaler) error { | ||
| // TODO(rfratto): allow this to write the value of the array instead of | ||
| // placeholder text. | ||
| fe.fields = append(fe.fields, fe.keyName(key), "<array>") | ||
| return nil | ||
| } | ||
|
|
||
| func (fe *fieldEncoder) AddObject(key string, marshaler zapcore.ObjectMarshaler) error { | ||
| // TODO(rfratto): allow this to write the value of the object instead of | ||
| // placeholder text. | ||
| fe.fields = append(fe.fields, fe.keyName(key), "<object>") | ||
| return nil | ||
| } |
There was a problem hiding this comment.
I didn't implement these here because:
- I think they're going to be a massive pain.
- I suspect logging arrays and objects is going to be fairly uncommon.
mattdurham
approved these changes
Oct 3, 2022
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces component/otelcol/internal/zapadapter, which creates a *zap.Logger instance from a github.com/go-kit/log.Logger instance. This is then used when creating OpenTelemetry Collector components, allowing us to continue to use github.com/go-kit/log consistently throughout Flow.
Related to #2213.