-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelcol.processor.batch: new component #2333
Conversation
Introduce a `otelcol.processor.batch` component which wraps around the upstream batch processor. Closes grafana#2285.
d60c1ac
to
dfde58e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
docs/sources/flow/reference/components/otelcol.processor.batch.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.batch.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.batch.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.batch.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.batch.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.batch.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.batch.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.batch.md
Outdated
Show resolved
Hide resolved
default, telemetry data will be dropped. To send telemetry data to other | ||
components, configure the `metrics`, `logs`, and `traces` arguments | ||
accordingly. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it OK that we don't have examples for otelcol.processor.batch and otelcol.processor.batch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm planning on adding examples after #2288 is implemented (since that would allow examples for an entire pipeline of OpenTelemetry Collector components)
SendBatchMaxSize uint32 `river:"send_batch_max_size,attr,optional"` | ||
|
||
// Output configures where to send processed data. Required. | ||
Output *otelcol.ConsumerArguments `river:"output,block"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to reuse the forward_to
terminology we used for Prometheus, or is this more in-line with what OTel does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, I think we need to think about it after we have a good set of otelcol components in. It might make sense for us to use different terminology just to help prevent confusing things (i.e., assume that you can use forward_to to send data to a prometheus.*
receiver)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR Description
Introduce a new
otelcol.processor.batch
component.Which issue(s) this PR fixes
Closes #2285.
Notes to the Reviewer
PR Checklist