Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelcol.exporter.otlp: new component #2343

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Oct 11, 2022

Introduce an otelcol.exporter.otlp component which wraps around the upstream otlp (gRPC) exporter.

I've left two pieces of work to be done in future PRs:

Closes #2288.

@rfratto rfratto requested a review from karengermond as a code owner October 11, 2022 19:05
Introduce an `otelcol.exporter.otlp` component which wraps around the
upstream otlp (gRPC) exporter.

Closes grafana#2288.
Copy link
Contributor

@karengermond karengermond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits on naming but LGTM

Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, live reviewed

@rfratto rfratto enabled auto-merge (squash) October 12, 2022 17:14
@rfratto rfratto merged commit e099fac into grafana:main Oct 12, 2022
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow: otelcol.exporter.otlp component
3 participants