-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelcol.exporter.otlp: new component #2343
Conversation
Introduce an `otelcol.exporter.otlp` component which wraps around the upstream otlp (gRPC) exporter. Closes grafana#2288.
ea75a88
to
523725c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
docs/sources/flow/reference/components/otelcol.exporter.otlp.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.otlp.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.otlp.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.otlp.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.otlp.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.otlp.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.otlp.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.otlp.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.otlp.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.otlp.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.exporter.otlp.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits on naming but LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, live reviewed
Introduce an
otelcol.exporter.otlp
component which wraps around the upstream otlp (gRPC) exporter.I've left two pieces of work to be done in future PRs:
otelcol.exporter.otlp
doesn't support authentication yet.otelcol
components #2345Closes #2288.