Convert to using prometheus appendable #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # component/prometheus/relabel/relabel.go # component/prometheus/remotewrite/remote_write.go
rfratto
reviewed
Oct 26, 2022
mattdurham
changed the title
rfratto
reviewed
Oct 26, 2022
* separate fanout and intercept patterns * testing flow * Add middleware style next to interceptor.
rfratto
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
LGTM! My only big concern is to change the fanout to not hide errors, since there's a few important things that depend on errors being returned. For example, the target should be marked as failed if it couldn't be written to the WAL (such as having invalid or duplicate labels).
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This switches over to using the storage.appendable/appender interfaces. Exemplars and metadata aren't supported but the hooks are all there. I didn't want to overload this PR.
Which issue(s) this PR fixes
Closes #2037
Notes to the Reviewer
PR Checklist