Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelcol.receiver.zipkin: new component #2685

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Jan 6, 2023

This commit adds otelcol.receiver.zipkin as a new Flow component, wrapping around the upstream zipkin receiver from the OpenTelemetry Collector otelcol-contrib distribution.

otelcol.receiver.zipkin spawns an HTTP server which can read Zipkin-formatted traces over the network.

Closes #2293.

@rfratto rfratto requested a review from mattdurham January 6, 2023 17:00
@rfratto rfratto requested a review from karengermond as a code owner January 6, 2023 17:00
@rfratto rfratto force-pushed the otelcol.receiver.zipkin branch from e786473 to e1e83e2 Compare January 6, 2023 17:01
Copy link
Contributor

@karengermond karengermond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple of edits

This commit adds otelcol.receiver.zipkin as a new Flow component,
wrapping around the upstream zipkin receiver from the OpenTelemetry
Collector otelcol-contrib distribution.

otelcol.receiver.zipkin spawns an HTTP server which can read
Zipkin-formatted traces over the network.

Closes grafana#2293.
@rfratto rfratto force-pushed the otelcol.receiver.zipkin branch from 9990266 to a507067 Compare January 7, 2023 01:02
@rfratto rfratto requested a review from mattdurham January 9, 2023 16:11
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfratto rfratto merged commit 0aad04c into grafana:main Jan 9, 2023
@rfratto rfratto deleted the otelcol.receiver.zipkin branch January 9, 2023 16:36
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow: otelcol.receiver.zipkin component
3 participants