Supprt TLS insecure skip verify for tempo #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will bump the opentelemetry-collector to v.0.16.0 which now supports insecure_skip_verify for TLS. This can be configured under the push_config to be passed to the otel collector.
|
|
rfratto
approved these changes
Dec 7, 2020
|
Awesome! Thanks for the suuuper quick turnaround! 🎉 |
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* Add support to skip TLS verification for Tempo exporter This will bump the opentelemetry-collector to v.0.16.0 which now supports insecure_skip_verify for TLS. This can be configured under the push_config to be passed to the otel collector. * Run go mod tidy to fix go.mod/go.sum * Vendor dependencies after update go.mod * Document Opentemetry-collector bump in CHANGELOG * docs: Add insecure_skip_verify to tempo_config section Co-authored-by: Robert Fratto <robertfratto@gmail.com>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This adds support to have the Tempo Open Telemetry exporter use insecure skip verify for TLS. This was added in
opentelemetry-collectorv0.16.0 so this PR also updates the dependency.Which issue(s) this PR fixes
Closes #257
Closes #272
Notes to the Reviewer
Since we had breaking changes in the
opentelemetry-collector, a small change has been made topkg/tempo/promsdprocessor/prom_sd_processor.gosince the resource no longer has aIsNil()method.PR Checklist