Revert "Add an otelcol.processor.attributes component (#3349)" #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 84a6494.
spartan0x117
approved these changes
Apr 21, 2023
docs/sources/flow/reference/components/mimir.rules.kubernetes.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Mischa Thompson <mischabear@gmail.com>
Co-authored-by: Mischa Thompson <mischabear@gmail.com>
ptodev
commented
Apr 21, 2023
docs/sources/flow/reference/components/otelcol.processor.batch.md
Outdated
Show resolved
Hide resolved
spartan0x117
added a commit
that referenced
this pull request
Apr 21, 2023
* Revert "Add an otelcol.processor.attributes component (#3349)" This reverts commit 84a6494. * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <mischabear@gmail.com> * Update docs/sources/flow/reference/components/mimir.rules.kubernetes.md Co-authored-by: Mischa Thompson <mischabear@gmail.com> * Update docs/sources/flow/reference/components/otelcol.processor.batch.md --------- Co-authored-by: Mischa Thompson <mischabear@gmail.com>
captncraig
pushed a commit
that referenced
this pull request
Apr 21, 2023
#3593) * Revert "Add an otelcol.processor.attributes component (#3349)" This reverts commit 84a6494. * Update docs/sources/flow/reference/components/discovery.kubernetes.md * Update docs/sources/flow/reference/components/mimir.rules.kubernetes.md * Update docs/sources/flow/reference/components/otelcol.processor.batch.md --------- Co-authored-by: Paulin Todev <paulin.todev@gmail.com>
ptodev
added a commit
that referenced
this pull request
Apr 28, 2023
ptodev
added a commit
that referenced
this pull request
May 9, 2023
ptodev
added a commit
that referenced
this pull request
May 31, 2023
ptodev
added a commit
that referenced
this pull request
Jun 12, 2023
ptodev
added a commit
that referenced
this pull request
Jun 14, 2023
ptodev
added a commit
that referenced
this pull request
Jun 14, 2023
* Revert "Revert "Add an otelcol.processor.attributes component (#3349)" (#3589)" This reverts commit fc17c56. * Add runner tests for the attributes processor * Update docs/sources/flow/reference/components/otelcol.processor.attributes.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * Remove a panic, fix comments and docs * Update changelog --------- Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Revert "Add an otelcol.processor.attributes component (#3349)" This reverts commit 84a6494. * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <mischabear@gmail.com> * Update docs/sources/flow/reference/components/mimir.rules.kubernetes.md Co-authored-by: Mischa Thompson <mischabear@gmail.com> * Update docs/sources/flow/reference/components/otelcol.processor.batch.md --------- Co-authored-by: Mischa Thompson <mischabear@gmail.com>
clayton-cornell
added a commit
that referenced
this pull request
Aug 14, 2023
* Revert "Revert "Add an otelcol.processor.attributes component (#3349)" (#3589)" This reverts commit fc17c56. * Add runner tests for the attributes processor * Update docs/sources/flow/reference/components/otelcol.processor.attributes.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * Remove a panic, fix comments and docs * Update changelog --------- Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Revert "Add an otelcol.processor.attributes component (#3349)" This reverts commit 84a6494. * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <mischabear@gmail.com> * Update docs/sources/flow/reference/components/mimir.rules.kubernetes.md Co-authored-by: Mischa Thompson <mischabear@gmail.com> * Update docs/sources/flow/reference/components/otelcol.processor.batch.md --------- Co-authored-by: Mischa Thompson <mischabear@gmail.com>
clayton-cornell
added a commit
that referenced
this pull request
Aug 14, 2023
* Revert "Revert "Add an otelcol.processor.attributes component (#3349)" (#3589)" This reverts commit fc17c56. * Add runner tests for the attributes processor * Update docs/sources/flow/reference/components/otelcol.processor.attributes.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * Remove a panic, fix comments and docs * Update changelog --------- Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
otelcol.processor.attributesfor now, because it does not seem to work with all signal types.The Test_ExcludeMulti test fails with this error:
The issue is that we pass the logs processor incompatible match properties. ValidateForLogs complains because there are "services" specified, which otel doesn't expect for logs.