chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml
#3761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@captncraig, this looks good to me but also wanted to ensure you or @spartan0x117 had some eyes on this. |
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
captncraig
approved these changes
May 12, 2023
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The
github.com/ghodss/yamlpackage is no longer being actively maintained.sigs.k8s.io/yamlis a permanent fork ofgithub.com/ghodss/yaml, which is actively maintained by Kubernetes SIG and widely used in K8s projects.There is a bug in
go mod tidythat doesn't rearrange direct and// indirectdependencies (golang/go#56471), so I had to manually joinrequireblocks and usego mod tidyto split them again.Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist