Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kubernetes tests #4161

Merged
merged 5 commits into from
Jun 15, 2023
Merged

Fix Kubernetes tests #4161

merged 5 commits into from
Jun 15, 2023

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Jun 15, 2023

Temporarily switch to a fork of testcontainers-go which has a fix for the k3s module so our tests work again when running from within a container.

I've opened testcontainers/testcontainers-go#1289 to upstream the fix; I'll update this PR to use upstream instead of my fork once that PR is merged.

@rfratto rfratto marked this pull request as ready for review June 15, 2023 14:59
@rfratto rfratto requested a review from a team as a code owner June 15, 2023 14:59
Copy link
Contributor

@erikbaranowski erikbaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfratto rfratto enabled auto-merge (squash) June 15, 2023 15:06
@rfratto rfratto disabled auto-merge June 15, 2023 15:06
@rfratto rfratto enabled auto-merge (squash) June 15, 2023 15:06
@rfratto rfratto merged commit be10ede into grafana:main Jun 15, 2023
@rfratto rfratto deleted the fix-k8s-tests branch June 15, 2023 16:01
clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
* util/k8s: fix panic when container failed to be created

* misc: update version of k3s module to temporary fork
clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
* util/k8s: fix panic when container failed to be created

* misc: update version of k3s module to temporary fork
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants