Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "go mod tidy" #419

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Fix "go mod tidy" #419

merged 2 commits into from
Feb 19, 2021

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Feb 19, 2021

PR Description

Excludes the grpc examples package conflict which was imported through opentelemetry-collector. go mod tidy works again! 🎉

Which issue(s) this PR fixes

Notes to the Reviewer

(Also testing what happens if we remove GOGC=10, which was inherited from Loki)

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@rfratto rfratto merged commit f485016 into grafana:main Feb 19, 2021
@rfratto rfratto deleted the fix-go-mod-tidy branch February 19, 2021 20:15
@rfratto
Copy link
Member Author

rfratto commented Feb 20, 2021

Turns out this only fixes go mod tidy for Go >=1.16, but I'll accept that tradeoff.

@mattdurham mattdurham mentioned this pull request Sep 7, 2021
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
* fixes a conflict in go mod tidy by explicitly excluding the package we don't want

* fix indentation
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants